Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter annotated by JsonInclude.Include.CUSTOM does not get called if the field is null with Afterburner/Blackbird module registered #190

Closed
cowtowncoder opened this issue Dec 5, 2022 · 2 comments
Closed

Filter annotated by JsonInclude.Include.CUSTOM does not get called if the field is null with Afterburner/Blackbird module registered #190

cowtowncoder opened this issue Dec 5, 2022 · 2 comments
Labels
afterburner blackbird Issue related to Blackbird module
Milestone
2.15.0

Comments

@cowtowncoder
Copy link
Member

(note: actual issue linked with original FasterXML/jackson-databind#3689)

See FasterXML/jackson-databind#3689 for details on reproduction.

Solution is two-part:

  1. Add reproduction test(s) for Afterburner and Blackbidr
  2. Copy code changes from jackson-databind wrt PropertyWriters

Depending on scope may be fixed for 2.14 (ideally) or 2.15 (if too big changes).
@cowtowncoder cowtowncoder added afterburner blackbird Issue related to Blackbird module 2.14 labels Dec 5, 2022
@cowtowncoder cowtowncoder added 2.15 and removed 2.14 labels Jan 14, 2023
@cowtowncoder
Copy link
Member Author

Ok I can see the difference in Afterburner and Blackbird; can reproduce the failure with Afterburner (but for some reason not with Blackbird, odd).

cowtowncoder added a commit that referenced this issue Jan 17, 2023
@cowtowncoder
Merge pull request #192 from FasterXML/tatu/190-custom-null-filter-af…
1381e32 
…terburner

Fix #190: update Afterburner to use same logic as jackson-databind for custom filters
@cowtowncoder cowtowncoder modified the milestones: 2.10.0, 2.15.0 Jan 17, 2023
@cowtowncoder
Copy link
Member Author

Fixed in 2.15 for 2.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
afterburner blackbird Issue related to Blackbird module
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
1 participant
@cowtowncoder