Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pxcomp deal with missing data #136

Open
josephwb opened this issue Aug 27, 2020 · 4 comments
Open

pxcomp deal with missing data #136

josephwb opened this issue Aug 27, 2020 · 4 comments
Assignees

Comments

@josephwb
Copy link
Member

Not sure why, but for a certain data set pxcomp is looping forever. The stopping criterion expects a small number, but this value becomes -nan and so never completes. This alignment is longish (30K sites) and contains a lot of missing data (7%), so I don't yet know what is responsible...

@josephwb josephwb self-assigned this Aug 27, 2020
@josephwb
Copy link
Member Author

Indeed, the ratio that should be getting smaller is instead getting larger. Hmmmmmmmm....

@josephwb
Copy link
Member Author

josephwb commented Aug 27, 2020

Ugh. isnan and isinf do not work with fast-math, as it assumes all math involved is finite and NaNs do not exist. Considering whether it is needed (or what alternatives might be available).

@josephwb josephwb mentioned this issue Apr 27, 2021
@josephwb
Copy link
Member Author

I believe this has to do with missing data, which are not supported. When we count the (valid) characters, the row totals get messed up, so we are not even doing a valid chi-square test anymore. This should be fixed with 7457e45.

@josephwb josephwb changed the title pxcomp stuck in loop pxcomp deal with missing data Apr 27, 2021
@josephwb
Copy link
Member Author

josephwb commented Apr 27, 2021

Changing this issue to reflect that missing data are not supported.

Can either: 1) through out columns with missing data or 2) something smarter (divide each amongst code states)? Check that p4/PAUP do in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant