Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program that collapses poorly supported edges #52

Open
josephwb opened this issue Jan 31, 2017 · 6 comments
Open

Program that collapses poorly supported edges #52

josephwb opened this issue Jan 31, 2017 · 6 comments

Comments

@josephwb
Copy link
Member

Pretty simple, but very useful!

User will provide a tree file and a minimum threshold: any edge with support < threshold gets collapsed.

@josephwb
Copy link
Member Author

Possible option: if tree is ultrametric (i.e., a chronogram) deal with edge lengths to preserve ultrametricity.

ultra
(Whenever I read "ultrametricity" (am I the only one who uses this word?) I automatically hear Will Ferrell's voice)

@josephwb
Copy link
Member Author

Hmm this is a bit trickier than at first sight. Specifically: there are 1) a tons of formats (e.g. annotated Nexus files like from FigTree vs. plain newick), and 2) support ranges (percentage vs. proportion).

For first stab, will expect simple proportion node labels: )0.4

@josephwb
Copy link
Member Author

josephwb commented Apr 15, 2018

Good start with 507ba56. Currently works with newicks with support as floats (TEST/collapse.tre). Handling integer support values should be straightforward.

@josephwb
Copy link
Member Author

91f6844 handles trees with either proportions or percentages for support values (guesses the scale by the first one encountered). Part of this involved the decision to force the threshold passed in to be a proportion. If the tree itself has percentages, this should be detected. The point of this 'guessing' is to allow a default threshold of 0.5 support (which may be typical).

Parsing Nexus node annotations will be next.

@josephwb
Copy link
Member Author

Ack, this is another that got forgotten. Looks like this got pretty far. Will look into this more tomorrow.

@josephwb
Copy link
Member Author

josephwb commented Jul 9, 2021

The only thing remaining here is the processing of annotated nexus files e.g. those produced by figtree/treeannotator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant