Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows vs adwaita shadows #32

Open
darkblaze69 opened this issue Oct 10, 2023 · 4 comments
Open

Shadows vs adwaita shadows #32

darkblaze69 opened this issue Oct 10, 2023 · 4 comments

Comments

@darkblaze69
Copy link

Couple issues regarding shadows.

  • when a window is not in focus it's shadowless.
  • the shadow is too contrast, radius too small. The adwaita shadow looks more diffused and more radius.

If it's not actionable feel free to close the issue ))

@joshas
Copy link

joshas commented Nov 19, 2023

Something strange is going on with those shadows, I assume we are going for "new" Adwaita theme, one new GTK4 applications are using? Let's do some visual inspection and compare some applications for reference. I am using Fedora Linux 39, with Wayland session. First, GNOME Calculator 45.0.2 on dark background:
image
And white background:
image
Window state is active.

When window is deactivated, whole window fades, but shadow stays the same:
image

Now, for my personal biggest annoyance, KeepassXC 2.7.6:
image
On dark background shadow is offset by several pixels, doesn't have border radius and even glows for some reason.
Inactive window fades a bit, as it should, but shadow disappears:
image

And finally, KeepassXC menus and modal window (About) have no shadows at all, nor expected round borders, although menu margins are added:
image
I would asume modal window should have not only shadow, but some window decorations too:
image

I apologize for a long rant, and appreciate all work that was done to make Qt applications look well integrated on GNOME desktop environment. I understand, that there are probably lots of limitations from Qt side, and from application itself, e.g. what widgets they are using. But still, I would be very interested in helping to improve QAdvaitaDecorations, so Qt applications could look identical to GTK4 ones, as much as possible.

@bertini97
Copy link
Contributor

@joshas If you want a quick and easy fix for the shadows, building QAdwaitaDecorations is really easy, and you just need to modify ceShadowsWidth to something slightly more (or less). I remember obtaining good results with it.

Also, it seems to be tied with the ceWindowBorderWidth, which has some other problems, like making it so when the window is maximized, a 1px slice of the desktop is visible. To magnify this effect, try setting it to 10 and then maximizing a window.

@LSeelig
Copy link

LSeelig commented Jan 27, 2024

I use the rounded window corners GNOME extension, which also makes them more inline with libadwaita and replaces the shadows. You will need to make a custom entry for each QT app and change the clip padding to 2.0, and this will technically cut into the border (but it will look much cleaner than 1.0, which improperly stacks the border.

@bertini97 bertini97 mentioned this issue Jun 2, 2024
@bertini97
Copy link
Contributor

@joshas just a heads up to #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants