Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing style when Fusion is explicitly set is a little rude #151

Open
rburchell opened this issue Aug 25, 2023 · 0 comments
Open

Forcing style when Fusion is explicitly set is a little rude #151

rburchell opened this issue Aug 25, 2023 · 0 comments

Comments

@rburchell
Copy link

In QGnomePlatformTheme::QGnomePlatformTheme, there's the following code:

    // if the user has explicitly set something else, don't meddle
    // Also ignore the default Fusion style
    if (!QQuickStyle::name().isEmpty() && QQuickStyle::name() != QLatin1String("Fusion")) {
        return;
    }

This seems a little rude; it means that if I'm developing an application that relies on that style (which is how this originally bit me), I'm not able to use it while also using QGnomePlatform.

Wouldn't it be better to do something like recommend that QT_QUICK_CONTROLS_STYLE=org.kde.desktop be set in the environment when packaging QGnomePlatform (and also that a dependency, or at least a recommended dependency, be added)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant