Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having mesh files in the example be downloaded as a part of building the docs is surprising #1033

Open
KristofferC opened this issue Jul 31, 2024 · 0 comments · May be fixed by #1037
Open
Assignees

Comments

@KristofferC
Copy link
Collaborator

I was wondering how the heck

grid = get_ferrite_grid(joinpath(@__DIR__, "porous_media_0p25.inp"))

was working when I couldn't find a reference to it in the repo or anywhere.

In my opinion it is better to download it as a part of the example so that you can just include the file. As it is right now, how are you supposed to know where the file is even coming from?

@KnutAM KnutAM self-assigned this Jul 31, 2024
@KnutAM KnutAM linked a pull request Aug 2, 2024 that will close this issue
@KnutAM KnutAM linked a pull request Sep 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants