Update topology_optimization.jl #898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiplication of the number of iterations needed for stability (n_j) with the viscosity (\eta) within the function update_density. If n_j is bigger than 1, behavior similar to checkerboarding could be observed otherwise.
|
The animation of the example should probably be updated to match this as well then? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 36 36
Lines 5257 5257
=======================================
Hits 4905 4905
Misses 352 352 ☔ View full report in Codecov by Sentry. |
|
The animation is fine, because N_j seems to be equal 1. |
|
I guess there's something missing in the theory section of the example then? |
Added reference for density update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiplication of the number of iterations needed for stability (n_j) with the viscosity (\eta) within the function update_density. If n_j is bigger than 1, behavior similar to checkerboarding could be observed otherwise. This solves issue #897.