Found a few further issues or bugs while testing the configs.

[khaep]

Hello all,

in relation to the bugfix mentioned here, I pulled the updates from the ros2 branch, built the package again with colcon buildand test the other configs from the config folder.

Thereby some other issues occured that indicate other bugs.
The config files with the corresponding error messages are listed below.

------------------------------fre21_task_1------------------------------

ros2 run virtual_maize_field generate_world fre21_task_1

Error message:

Traceback (most recent call last):
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/virtual_maize_field/generate_world", line 33, in <module>
    sys.exit(load_entry_point('virtual-maize-field==4.7.3', 'console_scripts', 'generate_world')())
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/generate_world.py", line 174, in main
    generator.generate()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/generate_world.py", line 31, in generate
    generated_sdf, heightmap = self.fgen.generate()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 167, in generate
    self.generate_ground()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 470, in generate_ground
    height = heightmap[py, px]
IndexError: index 2101 is out of bounds for axis 1 with size 2049
[ros2run]: Process exited with failure 1

------------------------------fre21_task_1_fast------------------------------

ros2 run virtual_maize_field generate_world fre21_task_1_fast

Error message:

Traceback (most recent call last):
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/virtual_maize_field/generate_world", line 33, in <module>
    sys.exit(load_entry_point('virtual-maize-field==4.7.3', 'console_scripts', 'generate_world')())
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/generate_world.py", line 174, in main
    generator.generate()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/generate_world.py", line 31, in generate
    generated_sdf, heightmap = self.fgen.generate()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 167, in generate
    self.generate_ground()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 470, in generate_ground
    height = heightmap[py, px]
IndexError: index 129 is out of bounds for axis 1 with size 129
[ros2run]: Process exited with failure 1

------------------------------fre21_task_3------------------------------

ros2 run virtual_maize_field generate_world fre21_task_3

Error message:

Traceback (most recent call last):
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/virtual_maize_field/generate_world", line 33, in <module>
    sys.exit(load_entry_point('virtual-maize-field==4.7.3', 'console_scripts', 'generate_world')())
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/generate_world.py", line 174, in main
    generator.generate()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/generate_world.py", line 31, in generate
    generated_sdf, heightmap = self.fgen.generate()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 169, in generate
    self.render_to_template()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 574, in render_to_template
    object_coordinates = [
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 575, in <listcomp>
    into_dict(
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/field_2d_generator.py", line 529, in into_dict
    coordinate["custom_visual"] = model.get_model_visual()
  File "/home/user/00_code/tutorials/test_ws/install/virtual_maize_field/lib/python3.10/site-packages/virtual_maize_field/world_generator/models.py", line 29, in get_model_visual
    assert model_folder.is_dir(), f"Cannot find model {self.model_name}!"
AssertionError: Cannot find model nettle!
[ros2run]: Process exited with failure 1

Same error for fre21_task_3_fast.yaml and fre21_task_3_mini.yaml.

------------------------------fre22_task_mapping------------------------------

ros2 run virtual_maize_field generate_world fre22_task_mapping

Error message:

Error: Cannot find any model matching the regular expression '(dandelion_[0-9]+)' in the models folder! Did you add the models to that folder?
[ros2run]: Process exited with failure 1

Same error for fre22_task_mapping_fast.yaml and fre22_task_mapping_mini.yaml.

Can you please provide a bug fix or a hint how to solve this problem?

Kind regards

[Rick-v-E]

Thanks for testing!

The fre22_task_mapping worlds needs dandelion models. These were not open-source and only distributed among the competitors of last years event. Therefore, you cannot build these. Probably this should be clarified in the readme somewhere.

The IndexError only happens sometimes if I am correct. Rerunning ros2 run virtual_maize_field generate_world fre21_task_1_fast should work.

Furthermore, there was an error in the ROS2 code for generating ros2 run virtual_maize_field generate_world fre21_task_3. That should be solved when #46 is merged.

[khaep]

Thanks for the information.
Are you planning to merge #46 in foreseeable future to solve the error from ros2 run virtual_maize_field generate_world fre21_task_3?

[Rick-v-E]

I will merge it now, however, the IndexError still exists. If you encounter it, just rerun the generate_world script.

[khaep]

Thanks for merging.
After pulling the changes, the AssertionError: Cannot find model nettle! in fre21_task_3 was fixed as described above.

However, it would be nice to have a fix for the IndexError. But you are right, running multiple times works so far.

[Rick-v-E]

I agree, however I could not find a quick fix yet. I'll leave this issue open till it's resolvd.