Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stormcloud with storm-cloud #22

Closed
gargajit opened this issue Mar 9, 2023 · 3 comments
Closed

Replace stormcloud with storm-cloud #22

gargajit opened this issue Mar 9, 2023 · 3 comments

Comments

@gargajit
Copy link
Contributor

gargajit commented Mar 9, 2023

As discussed with @amitu, the component name stormcloud contains two separate words therefore there has to be a hyphen between storm and cloud.
Repository Name: bling/quote

@amitu
Copy link
Member

amitu commented Mar 9, 2023

@gargajit, @gsalunke please review the names of other components in this package as well. We do not combine two words into one without dash.

@gargajit
Copy link
Contributor Author

gargajit commented Mar 9, 2023

The issue has been fixed. The name of the component stormcloud has been renamed to storm-cloud.
The changes are live.
URL: https://fifthtry.github.io/bling/quote/

@gargajit gargajit closed this as completed Mar 9, 2023
@gsalunke
Copy link
Contributor

gsalunke commented Mar 9, 2023

@gargajit, @gsalunke please review the names of other components in this package as well. We do not combine two words into one without dash.

@amitu
Thank you for your feedback.
We have created a separate issue to fix all such component names where we used two words and not added - hyphen.

Issue:
#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants