Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename models.File to models.Note across the application #192

Open
sethwoodworth opened this issue Dec 17, 2012 · 3 comments
Open

Rename models.File to models.Note across the application #192

sethwoodworth opened this issue Dec 17, 2012 · 3 comments

Comments

@sethwoodworth
Copy link
Member

Do this in all:

  • variable
  • class
  • function names
  • docstrings and comments
  • user-facing text
@ghost ghost assigned CharlesHolbrow Dec 17, 2012
@CharlesHolbrow
Copy link
Member

Stackoverflow post with a good way to do this:

http://stackoverflow.com/a/2899145

@CharlesHolbrow
Copy link
Member

We will need to manually modify the schema migration. Models with ForeinKey(Note) or ForeignKey('Note') members will need to be included.

class Vote(models.model) has
note = models.ForeignKey(File)

class ReputationEvent(models.model) has
file = models.ForeignKey(File, blank=True, null=True)

class UserProfile(models.model) has
files = models.ManyToManyField(File, blank=True, null=True)

@sethwoodworth
Copy link
Member Author

This is very close to complete. There are a few function names that refer to file that need to be reworked, but that can happen when we restructure to class-based views. I'm not going to check this off until we test the refactor branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants