From 3d5ff99729b22bd2007808fd44bb9742a80e202b Mon Sep 17 00:00:00 2001 From: Matt Brennan Date: Tue, 6 Nov 2018 14:45:46 +0000 Subject: [PATCH] sessionId no longer used --- components/x-gift-article/readme.md | 15 +++++++-------- components/x-gift-article/stories/native-share.js | 1 - .../x-gift-article/stories/with-gift-credits.js | 1 - 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/components/x-gift-article/readme.md b/components/x-gift-article/readme.md index 9cf666946..fe2cba718 100644 --- a/components/x-gift-article/readme.md +++ b/components/x-gift-article/readme.md @@ -14,12 +14,12 @@ npm install --save @financial-times/x-gift-article ## Styling -To get correct styling, Your app should have origami components below. -[o-fonts](https://registry.origami.ft.com/components/o-fonts) -[o-buttons](https://registry.origami.ft.com/components/o-buttons) -[o-forms](https://registry.origami.ft.com/components/o-forms) -[o-loading](https://registry.origami.ft.com/components/o-loading) -[o-share](https://registry.origami.ft.com/components/o-share) +To get correct styling, Your app should have origami components below. +[o-fonts](https://registry.origami.ft.com/components/o-fonts) +[o-buttons](https://registry.origami.ft.com/components/o-buttons) +[o-forms](https://registry.origami.ft.com/components/o-forms) +[o-loading](https://registry.origami.ft.com/components/o-loading) +[o-share](https://registry.origami.ft.com/components/o-share) [o-message](https://registry.origami.ft.com/components/o-message) ## Usage @@ -36,7 +36,7 @@ const b = ; const c = React.createElement(GiftArticle, props); ``` -Your app should dispatch a custom event (`xDash.giftArticle.activate`) to activate the gift article form when your app actually displays the form. +Your app should dispatch a custom event (`xDash.giftArticle.activate`) to activate the gift article form when your app actually displays the form. `document.body.dispatchEvent(new CustomEvent('xDash.giftArticle.activate'));` All `x-` components are designed to be compatible with a variety of runtimes, not just React. Check out the [`x-engine`][engine] documentation for a list of recommended libraries and frameworks. @@ -52,7 +52,6 @@ Property | Type | Required | Note `articleUrl` | String | yes | Canonical URL `articleTitle` | String | yes | `articleId` | String | yes | Content UUID -`sessionId` | String | yes | This is needed to get a gift url. `showMobileShareLinks` | Boolean | no | `nativeShare` | Boolean | no | This is a property for App to display Native Sharing. `apiProtocol` | String | no | The protocol to use when making requests to the gift article and URL shortening services. Ignored if `apiDomain` is not set. diff --git a/components/x-gift-article/stories/native-share.js b/components/x-gift-article/stories/native-share.js index 377fe05f9..a42fe98e9 100644 --- a/components/x-gift-article/stories/native-share.js +++ b/components/x-gift-article/stories/native-share.js @@ -11,7 +11,6 @@ exports.data = { articleUrl, articleTitle: 'Title Title Title Title', articleId, - sessionId: 'session id', nativeShare: true, id: 'base-gift-article-static-id' }; diff --git a/components/x-gift-article/stories/with-gift-credits.js b/components/x-gift-article/stories/with-gift-credits.js index 1b592664d..85e98e091 100644 --- a/components/x-gift-article/stories/with-gift-credits.js +++ b/components/x-gift-article/stories/with-gift-credits.js @@ -11,7 +11,6 @@ exports.data = { articleUrl, articleTitle: 'Title Title Title Title', articleId, - sessionId: 'session id', showMobileShareLinks: true, id: 'base-gift-article-static-id' };