From 40a4bcafb505458af06ce535b4de25d335bad812 Mon Sep 17 00:00:00 2001 From: ibrahim-mamdouh-ft Date: Thu, 29 Aug 2024 15:52:45 +0300 Subject: [PATCH 1/3] Fix includeHighlights initial value --- components/x-gift-article/src/GiftArticle.jsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/components/x-gift-article/src/GiftArticle.jsx b/components/x-gift-article/src/GiftArticle.jsx index d4925b715..b7537826f 100644 --- a/components/x-gift-article/src/GiftArticle.jsx +++ b/components/x-gift-article/src/GiftArticle.jsx @@ -263,7 +263,12 @@ const withGiftFormActions = withActions( return (state) => { state.highlight = document.querySelector(`.${state.highlightClassName}`)?.textContent state.highlightClassName = document.querySelector(`.${state.highlightClassName}`)?.classList.value - return { highlight: state.highlight, highlightClassName: state.highlightClassName } + state.includeHighlights = true + return { + highlight: state.highlight, + highlightClassName: state.highlightClassName, + includeHighlights: state.includeHighlights + } } } } @@ -296,7 +301,7 @@ const withGiftFormActions = withActions( isGiftUrlCreated: false, isGiftUrlShortened: false, isNonGiftUrlShortened: false, - includeHighlights: true, + includeHighlights: props.highlight !== undefined, showAdvancedSharingOptions: false, showNonSubscriberOptions: false, highlight: undefined, From 81868d8d06cf22fbab43354f97592e0c8d1a5002 Mon Sep 17 00:00:00 2001 From: ibrahim-mamdouh-ft Date: Thu, 29 Aug 2024 16:48:26 +0300 Subject: [PATCH 2/3] Add pro-diff team to CODEOWNERS --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 6f487640b..e0f641fe4 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -11,4 +11,4 @@ components/x-topic-search @Financial-Times/content-discovery components/x-live-blog-post @Financial-Times/storytelling components/x-live-blog-wrapper @Financial-Times/storytelling components/x-gift-article @Financial-Times/cp-retention-team - +components/x-gift-article @Financial-Times/professional-differentiate From 633700ba3db7bb325f3b0ee8ca4705c0d68497ce Mon Sep 17 00:00:00 2001 From: ibrahim-mamdouh-ft Date: Thu, 29 Aug 2024 16:56:20 +0300 Subject: [PATCH 3/3] Update codeowners --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index e0f641fe4..6f487640b 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -11,4 +11,4 @@ components/x-topic-search @Financial-Times/content-discovery components/x-live-blog-post @Financial-Times/storytelling components/x-live-blog-wrapper @Financial-Times/storytelling components/x-gift-article @Financial-Times/cp-retention-team -components/x-gift-article @Financial-Times/professional-differentiate +