Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate snapshot files for each component #152

Open
i-like-robots opened this issue Sep 4, 2018 · 1 comment
Open

Create separate snapshot files for each component #152

i-like-robots opened this issue Sep 4, 2018 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed housekeeping Cleaning things up

Comments

@i-like-robots
Copy link
Contributor

Because all component shapshots are currently pushed into a single file I am worried that any changes to components not currently under test may not be caught as I suspect people may only look at the part of the diff related to their component.
@i-like-robots i-like-robots added help wanted Extra attention is needed good first issue Good for newcomers housekeeping Cleaning things up labels Sep 4, 2018
@apaleslimghost
Copy link
Member

snapshot file paths are generated by the name of the test file that's generating them, and it's currently not configurable 😕 jestjs/jest#2676

@i-like-robots i-like-robots mentioned this issue Oct 9, 2018
Open
@apaleslimghost apaleslimghost mentioned this issue May 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed housekeeping Cleaning things up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make snapshot tests explicit in each component Financial-Times/x-dash
2 participants
@i-like-robots @apaleslimghost