Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make snapshot tests explicit in each component #277

Closed
wants to merge 3 commits into from
Closed

make snapshot tests explicit in each component #277

wants to merge 3 commits into from

Conversation

apaleslimghost
Copy link
Member

@apaleslimghost apaleslimghost commented Apr 25, 2019 •
edited
Loading

closes #196, fixes #152. we'll need to port this to the new components at some point; i think it'll be easier to wait until they're all merged before merging this to save on churn

@apaleslimghost apaleslimghost added the housekeeping Cleaning things up label Apr 29, 2019
@i-like-robots
Copy link
Contributor

i think it'll be easier to wait until they're all merged before merging this to save on churn

👍

@apaleslimghost
Copy link
Member Author

i'm actually going to do #196 instead. this will allow us to directly use storiesOf and hopefully enable #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-like-robots i-like-robots Awaiting requested review from i-like-robots

Assignees
No one assigned
Labels
housekeeping Cleaning things up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch jest snapshots to use storyshots Create separate snapshot files for each component
2 participants
@apaleslimghost @i-like-robots