Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new component creation/blueprint papercuts #198

Open
apaleslimghost opened this issue Oct 10, 2018 · 2 comments
Open

new component creation/blueprint papercuts #198

apaleslimghost opened this issue Oct 10, 2018 · 2 comments
Labels
documentation A problem with how something is documented (or, not) housekeeping Cleaning things up

Comments

@apaleslimghost
Copy link
Member

  • stories files are created but not hooked up to storybook
    • adding stories to storybook isn't documented any more
  • running storybook isn't enough to get hot reloading working; need to run npm start in the component
@apaleslimghost apaleslimghost added documentation A problem with how something is documented (or, not) housekeeping Cleaning things up labels Oct 10, 2018
@i-like-robots
Copy link
Contributor

stories files are created but not hooked up to storybook

I guess we could do some sort of Webpack magic here? The components.js file is no longer used as a source for docs IIRC so it's solely for Storybook now.

adding stories to storybook isn't documented any more

Oh bum, my bad.

running storybook isn't enough to get hot reloading working

As mentioned in #177 if Storybook could be run at the repository root we could point it directly at the source files.

@apaleslimghost
Copy link
Member Author

for 1 i was thinking the blueprint script could just munge register-components.js and package.json when it runs? pointing storybook at source files would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A problem with how something is documented (or, not) housekeeping Cleaning things up
Projects
None yet
Development

No branches or pull requests

2 participants