-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install takes 9 minutes #340
Comments
I think this is due to a combination of a few things:
If you'd like to try the install step or other commands without Athloi to see if it makes any difference to your setup here are a few scripts to help: Tasks in series: #!/bin/bash
start=$(date +%s)
find ./{components,packages,tools} -name '*' -depth 1 -exec bash -c "cd '{}' && npm i" \;
end=$(date +%s)
echo "duration: $((end-start)) seconds." And in parallel: #!/bin/bash
start=$(date +%s)
find ./{components,packages,tools} -name '*' -depth 1 -print0 | xargs -0 -L 1 -P 10 bash -c 'cd "$0" && npm i'
end=$(date +%s)
echo "duration: $((end-start)) seconds." (Using Athloi or vanilla bash shouldn't make any difference to speed but it's worth trying just in case) |
There are two major improvements we could make that I am currently aware of:
|
And to reiterate how how hard npm can have to fight for CPU, below are screenshots taken from activity monitor whilst running the install task. There are a few things here that might be worth investigating. Anecdotally... my laptop at home - which is not as powerful as my work machine - takes < half the time to install and run x-dash. Whatever the cause - this is something we need to improve. |
|
make install takes 9 minutes
the athloi task seems to be the slowest part
The text was updated successfully, but these errors were encountered: