From 019a20befa13c6adb0e3bf019f832e13f124437d Mon Sep 17 00:00:00 2001 From: minherz Date: Fri, 24 May 2024 14:04:25 -0700 Subject: [PATCH] chore: address review feedback Throw an error if `firebase.json` is missing. Print a neutral tracking log after processing GAC info --- src/index.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/index.ts b/src/index.ts index ae96a8f..06a0286 100644 --- a/src/index.ts +++ b/src/index.ts @@ -65,16 +65,12 @@ async function run() { if (existsSync("./firebase.json")) { console.log("firebase.json file found. Continuing deploy."); } else { - console.warn( + throw Error( "firebase.json file not found. If your firebase.json file is not in the root of your repo, edit the entryPoint option of this GitHub action." ); } const gacFilename = await createGacFile(googleApplicationCredentials); - if (gacFilename !== googleApplicationCredentials) { - console.log( - "Created a temporary file with Google Application Credentials." - ); - } + console.log("Google Application Credentials acquired."); endGroup(); if (configuredChannelId === "live") {