Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details_url not outputting for production deploys #213

Open
intelseb opened this issue Jun 2, 2022 · 2 comments · May be fixed by #302
Open

details_url not outputting for production deploys #213

intelseb opened this issue Jun 2, 2022 · 2 comments · May be fixed by #302
Labels
enhancement New feature or request

Comments

@intelseb
Copy link

intelseb commented Jun 2, 2022

The use case you're trying to solve

Production deploy doesn't set details_url output, but prints it in the action when run

Change to the action that would solve that use case

ensure that for production deployment code the following is set as say line 101 in file https://github.com/FirebaseExtended/action-hosting-deploy/blob/0f248036885ae672f78587669fa2923f0ef6cac2/src/index.ts

setOutput("details_url",url);

Other considerations

Although the url for production is known and static, for the purposes of using a github action, if the wiki says the output is available it should be, the Readme at https://github.com/FirebaseExtended/action-hosting-deploy#outputs should also be updated to reflect the following

urls
The url(s) deployed to (preview channels only)

expire_time
The time the deployed preview urls expire (preview channels only)

details_url
A single URL that was deployed to (production & preview)

@intelseb intelseb added the enhancement New feature or request label Jun 2, 2022
lopes-gustavo added a commit to RedemptionGames/action-hosting-deploy that referenced this issue Aug 17, 2023
lopes-gustavo added a commit to RedemptionGames/action-hosting-deploy that referenced this issue Aug 17, 2023
lopes-gustavo added a commit to RedemptionGames/action-hosting-deploy that referenced this issue Aug 17, 2023
@lopes-gustavo
Copy link

I opened a PR to fix this
#302

@pm0u
Copy link

pm0u commented May 23, 2024

So there is no way to get the deployed to URL for a production deploy? 😵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants