Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better security: Reduce the need for passing a service account key JSON file #399

Open
1 task
lucetre opened this issue Dec 7, 2024 · 1 comment
Open
1 task
Labels
enhancement New feature or request

Comments

@lucetre
Copy link

lucetre commented Dec 7, 2024

The use case you're trying to solve

Reduce the need for explicitly managing and passing a service account key JSON file. Better security practice.

Change to the action that would solve that use case

Other considerations

N/A

@lucetre lucetre added the enhancement New feature or request label Dec 7, 2024
@lucetre lucetre changed the title Better security practice: Reduce the need for passing a service account key JSON file Better security: Reduce the need for passing a service account key JSON file Dec 7, 2024
@lucetre
Copy link
Author

lucetre commented Dec 10, 2024

If we use the auth_token as serviceAccountToken, we are facing the below error simply speaking no way to use ADC;

  {
    "status": "error",
    "error": "Failed to authenticate, have you run \u001b[1mfirebase login\u001b[22m?"
  }{
    "status": "error",
    "error": "Failed to authenticate, have you run \u001b[1mfirebase login\u001b[22m?"
  }
  
  The process '/home/runner/_work/_tool/node/22.12.0/x64/bin/npx' failed with exit code 1
  Error: The process '/home/runner/_work/_tool/node/22.12.0/x64/bin/npx' failed with exit code 1
  {
    conclusion: 'failure',
    output: {
      title: 'Deploy preview failed',
      summary: "Error: The process '/home/runner/_work/_tool/node/22.12.0/x64/bin/npx' failed with exit code 1"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant