Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also add TryFindStructureDefinition() etc #3054

Open
ewoutkramer opened this issue Feb 20, 2025 · 0 comments
Open

Also add TryFindStructureDefinition() etc #3054

ewoutkramer opened this issue Feb 20, 2025 · 0 comments

Comments

@ewoutkramer
Copy link
Member

After doing PR review on #2778, I wondered where all the changes would go in the SDK code that is actually calling resolvers. Turns out, that most of our code does not directly call IResourceResolver members, but the derivatives, the extension methods on IResourceResolver like FindStructureDefinition. Since these did not get the TryXXXX treatment yet, there is still a lot of SDK code (e.g. the snapshot generator) that is now calling the new try methods, but hidden in these FindSSTructureDefinition methods, which just return null, like they always have.

To fully profit from these new changes, we should look at our uses of these extension methods, maybe mark them as Obsolete too and then make sure our own internal calls to IResourceResolver will exploit the new error detail information. I don't know whether this can be done after 6.0, since reporting back errors from something like the SnapshotGenerator may also require breaking changes.

So, at the least, we should do an investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant