Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/log: Proper reentrant logging #50

Open
notYuriy opened this issue May 14, 2021 · 1 comment
Open

lib/log: Proper reentrant logging #50

notYuriy opened this issue May 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@notYuriy
Copy link
Contributor

Reentrant logging, as it is implemented now, is barely useful. The only way reentracy could be helpful is iff there is an exception in the log function itself. However, this probably means that log state is corrupted anyways and log should not be trusted. Instead, there should be a trusted subset of log_nolock that would handle exceptions in log itself. For example, it can just output to e9.

@notYuriy notYuriy added the enhancement New feature or request label May 14, 2021
@N00byEdge
Copy link
Member

However, this probably means that log state is corrupted anyways and log should not be trusted.

Remember that each log subsystem (vesa_log, vga_log, platform) etc won't be reentered if you're inside them. If one of them panics, the other ones will print its panic message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants