Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GPUArrays 9 #1451

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Allow GPUArrays 9 #1451

merged 1 commit into from
Sep 1, 2023

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Sep 1, 2023

To allow latest CUDA, AMDGPU, etc. to work with Zygote.

PR Checklist

  • Tests are added
  • Documentation, if applicable

ToucheSir
ToucheSir approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. For those wondering, test failures are from the still-broken AbstractFFTs integration.

@ToucheSir ToucheSir merged commit 69c2616 into FluxML:master Sep 1, 2023
9 of 12 checks passed
@pxl-th pxl-th deleted the bump-gpu-arrays branch September 1, 2023 19:12
@pxl-th
Copy link
Member Author

pxl-th commented Sep 4, 2023 •
edited
Loading

@ToucheSir is it possible to tag a release or are there any blockers?

@ToucheSir
Copy link
Member

ToucheSir commented Sep 4, 2023 •
edited
Loading

I thought I had something else lined up, but looks like I didn't. Thanks for the reminder and will tag shortly.

E: JuliaRegistries/General#90801

@pxl-th
Copy link
Member Author

pxl-th commented Sep 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxl-th @ToucheSir