Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build instructions are not robust enough #319

Open
diggit opened this issue Oct 27, 2024 · 2 comments
Open

build instructions are not robust enough #319

diggit opened this issue Oct 27, 2024 · 2 comments

Comments

@diggit
Copy link

diggit commented Oct 27, 2024

Hi,
build instructions in readme assume the default cmake build backend is make which may not be the case (in my case it's Ninja which is faster than make).

Original

cd RyzenAdj
rm -r win32
mkdir build && cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
make
#...

Suggested

cd RyzenAdj
rm -r win32
cmake -B build -S . -DCMAKE_BUILD_TYPE=Release
cmake --build build
cd build
#...

What do you think?

Edit: fixed cmake args (upper case)

@Ken-g6
Copy link

Ken-g6 commented Dec 7, 2024

I decided to try this on Mint 22. At the first cmake I got:

CMake Warning:
  Ignoring extra path from command line:

   "[my full path to]/RyzenAdj/build"


CMake Error: Unknown argument -s
CMake Error: Run 'cmake --help' for all supported options.

@diggit
Copy link
Author

diggit commented Dec 7, 2024

@Ken-g6 sorry for that, I wrote this issue in hurry and forgot the correct case of arguments (upper case), fixed it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants