Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 - Deprecated error in nginx logs #205

Open
ghost opened this issue Jan 21, 2022 · 8 comments
Open

PHP 8.1 - Deprecated error in nginx logs #205

ghost opened this issue Jan 21, 2022 · 8 comments

Comments

@ghost
Copy link

ghost commented Jan 21, 2022

2022/01/21 16:58:57 [error] 3597#3597: *19956001 FastCGI sent in stderr: "PHP message: PHP Deprecated:  Return type of Foolz\SphinxQL\Drivers\ResultSet::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php on line 90"
@ghost
Copy link
Author

ghost commented Jan 21, 2022

VSCode PHP Intelephense is throwing some more errors by the way:

[{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::offsetExists()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::offsetExists()'.",
	"source": "intelephense",
	"startLineNumber": 90,
	"startColumn": 5,
	"endLineNumber": 90,
	"endColumn": 42
},{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::offsetSet()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::offsetSet()'.",
	"source": "intelephense",
	"startLineNumber": 108,
	"startColumn": 5,
	"endLineNumber": 108,
	"endColumn": 47
},{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::offsetUnset()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::offsetUnset()'.",
	"source": "intelephense",
	"startLineNumber": 117,
	"startColumn": 5,
	"endLineNumber": 117,
	"endColumn": 41
},{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::next()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::next()'.",
	"source": "intelephense",
	"startLineNumber": 136,
	"startColumn": 5,
	"endLineNumber": 136,
	"endColumn": 27
},{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::valid()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::valid()'.",
	"source": "intelephense",
	"startLineNumber": 152,
	"startColumn": 5,
	"endLineNumber": 152,
	"endColumn": 28
},{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::rewind()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::rewind()'.",
	"source": "intelephense",
	"startLineNumber": 164,
	"startColumn": 5,
	"endLineNumber": 164,
	"endColumn": 29
},{
	"resource": "/Users/REMOVED/Git/REMOVED/vendor/foolz/sphinxql-query-builder/src/Drivers/ResultSet.php",
	"owner": "_generated_diagnostic_collection_name_#3",
	"code": "1038",
	"severity": 8,
	"message": "Method 'Foolz\\SphinxQL\\Drivers\\ResultSet::count()' is not compatible with method 'Foolz\\SphinxQL\\Drivers\\ResultSetInterface::count()'.",
	"source": "intelephense",
	"startLineNumber": 179,
	"startColumn": 5,
	"endLineNumber": 179,
	"endColumn": 28
}]

@ghost
Copy link
Author

ghost commented Feb 14, 2022

Anyone who could perhaps take care of this?

@oohnoitz @MaxKorlaar

@MaxKorlaar
Copy link
Contributor

MaxKorlaar commented Feb 15, 2022

We @scholieren-com can pick this up later but I can't provide an ETA.

@NelinD
Copy link

NelinD commented Feb 24, 2022

@Fossil01 #204 solution?

@ghost
Copy link
Author

ghost commented Feb 24, 2022

I dunno, try it and let us know.

@NelinD
Copy link

NelinD commented Feb 24, 2022

@Fossil01 It work.
I use this fork.
Need merge and release.

@ghost
Copy link
Author

ghost commented Feb 25, 2022

I see @forgie1 has a fork as well where the actual return types have been added.

forgie1@ae9557a

@oohnoitz
Copy link
Contributor

I just a release for 3.0.2 which contains #204 merged in. If that does not resolve this, then please feel free to submit a PR to help get 8.1 compatibility up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants