-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flux standard action compliance? #5
Comments
Fork this library and write your own? You haven't explained why it doesn't work for you. It's very unclear that FSA is a good idea, or even widely used. |
FSA is notably used by |
+1 |
Having the same issue in an app that requires actions to be FSA. It would be nice to be able to configure where the optimist data is added for those of us using FSA to bring some consistency to action shape. |
You simply have to replace the bit of your redux stack that checks fsa shapes, with one that accepts an |
Maybe put optimist info into the meta field? |
Looking at the code, the Something like this: master...quicksnap:patch-1 The above is incomplete, but I think it could be made backward-compatible with current API. I like using FSAs personally, but I haven't found non-FSAs to cause me any trouble. Food for thought if anyone wants to complete the PR. |
@quicksnap I would be willing to accept that approach if completed along with a pull request since it potentially has value beyond FSAs. |
Might as well whip it up! Probably won't take too long. |
PR #9 |
If non-FSA actions break your middleware, I would consider that a bug with your middleware. |
What if I want my actions to be FSA-compliant? Some libraries such as redux-promise are best used with FSA, and having an "optimist" property does not work well for me personally.
The text was updated successfully, but these errors were encountered: