feat: better logs during timeout #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ae10e3f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (98% is the threshold). This pull request will bring the total coverage in the repository to 97.2%. View more on Code Climate. |
EnkiP
reviewed
Nov 13, 2024
| @@ -28,7 +29,11 @@ export default class ServerUtils { | |||
| return response.body; | |||
| } catch (error) { | |||
| if (error.timeout) { | |||
| throw new Error('The request to Forest Admin server has timeout'); | |||
| throw new Error( | |||
| `The request to Forest Admin server has timed out while trying to reach ${url} at ${new Date().toISOString()}. Message: ${ | |||
There was a problem hiding this comment.
toLocaleString is maybe a bit more readable
There was a problem hiding this comment.
I'm not sure.
Those logs are more destined to be analyzed by us.
ISO is standardized
EnkiP
approved these changes
Nov 13, 2024
4 tasks
forest-bot
added a commit
that referenced
this pull request
Nov 15, 2024
## [1.11.12](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.11.12) (2024-11-15) ### Features * better logs during timeout ([#1208](#1208)) ([e844184](e844184))
forest-bot
added a commit
that referenced
this pull request
Nov 15, 2024
## [1.53.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-11-15) ### Features * better logs during timeout ([#1208](#1208)) ([e844184](e844184))
|
🎉 This PR is included in version 1.12.4 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Nov 15, 2024
# [1.35.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-11-15) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
|
🎉 This PR is included in version 1.11.12 🎉 The release is available on Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.53.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Nov 20, 2024
## [1.5.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-11-20) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
forest-bot
added a commit
that referenced
this pull request
Nov 20, 2024
# [1.15.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-11-20) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
#86c0w754x
General
Security