Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the integration system pluggable #60

Open
louisremi opened this issue Mar 24, 2017 · 2 comments
Open

Make the integration system pluggable #60

louisremi opened this issue Mar 24, 2017 · 2 comments
Labels

Comments

@louisremi
Copy link
Contributor

Hi,

I'd like to integrate InvoiceNinja into Forest, by taking inspiration on the Stripe integration. After digging around the integration code, I realize it will be difficult for me to do that without forking forest-express.
It seems it could be easy to change https://github.com/ForestAdmin/forest-express/blob/devel/integrations/index.js#L5 to initialize modules with values passed through the liana options.

Before I open a pull request, I'd like to know if you would be willing to make the integration system pluggable.

Thanks :-)

@arnaudbesnier
Copy link
Member

Hey @louisremi , that's an interesting use case!
Why wouldn't you fork the repository to add InvoiceNinja integration? The community could be happy to use your contribution.

@louisremi
Copy link
Contributor Author

louisremi commented Mar 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants