Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Fix audit vulnerabilities for lodash and handlebars #579

Closed
mario-grx opened this issue Jun 23, 2021 · 2 comments
Closed

Fix audit vulnerabilities for lodash and handlebars #579

mario-grx opened this issue Jun 23, 2021 · 2 comments

Comments

@mario-grx
Copy link

Expected behavior

There are a couple of vulnerabilities that have been with lumber-cli for a while. I was wondering if it would be possible to fix them to get CI pipelines to pass automatically.

Actual behavior

Currently, lumber-cli is fixed to version 4.17.19 that has a high vulnerability. Also, it is linked to version 4.7.6 of handlebars that has a critical vulnerability.

The problem is that it makes fail our CI when checking for vulnerabilities and because they're fixed versions, we can't update them.

Remediation

There are two methods. One would be to merge the dependabot PRs to fix those issues.

However, there's another solution that unless there's a strong reason to dismiss might be a better solution. It would be to change the fixed versions to minimum versions. That way, everybody depending on lumber-cli would be able to upgrade any of these dependencies. I'm not sure what's the reason that lodash, handlebars or sequelize are pinned to specific versions, as they would not be upgraded to major versions but only to minor or patch ones.

Please consider doing so.

I offer to send the PR with those changes if you would approve it.

@das-peter
Copy link

Don't mind me - just linking related issues together.
Mentioned dependabot issues:
#568
#575

@slimee
Copy link
Contributor

slimee commented Jul 19, 2021

Hi,

The lumber-cli is now deprecated.
Please use instead forest-cli.

@slimee slimee closed this as completed Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants