Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Container size #9

Open
ai opened this issue Jul 20, 2015 · 8 comments
Open

Container size #9

ai opened this issue Jul 20, 2015 · 8 comments

Comments

@ai
Copy link
Contributor

ai commented Jul 20, 2015

React Shuffle logic is to have hidden block with real controls and visible block for animation with position: absolute on top of that hidden block.

But, as result, there is no comtainer size animation, when we delete item.

Example: this is my UX:
6cijeo0

When I will delete one of item, “minus” button will move immediately to the left. Because “minus button” is out of Shuffle container and Shuffle container size has no animation.

@ai
Copy link
Contributor Author

ai commented Jul 20, 2015

/cc @kenwheeler

@kenwheeler
Copy link
Contributor

Not sure I understand, video?

@kenwheeler
Copy link
Contributor

Oh wait, I know exactly what you are talking about. Does applying a CSS transition declaration fix this?

@ai
Copy link
Contributor Author

ai commented Jul 20, 2015

Ouh, I fix it in different way. I will test it on new control tomorrow. Is it OK?

@kenwheeler
Copy link
Contributor

Sure. It's hard to say exactly how to handle this, because the container could scale vertically or horizontally depending on which tiles were removed. And that's providing that the shuffle container is indeed the layout providing parent.

@kenwheeler
Copy link
Contributor

Out of curiosity, is this in use on VK?

@ai
Copy link
Contributor Author

ai commented Jul 20, 2015

Nope, we use it in Amplifr, “Buffer” for VK and other Russian networks :).

@kenwheeler
Copy link
Contributor

Thats awesome. Really cool landing page. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants