Add caching to tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready to be reviewed. |
|
I am happy to review it, since Laurent is on holiday this week. So if you are ok with this, I will go ahead. |
timlichtenberg
approved these changes
Jul 24, 2024
|
Cheers, I'll just merge it now then. If there need to be additional changes, I'm happy to fix it! |
lsoucasse
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Avoid running the same tests twice in a PR * Cache python venv install * Set up cache for socrates * Move apt install back to the top * Fix path and cache key * Pull to local directory * Fix path to version file * Trigger workflow * Add caching for FWL_DATA directory * Expand path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up caching for setting up JANUS and SOCRATES. This completely eliminates build times on repeated runs with the same SOCRATES or JANUS versions. This should reduce total test times by ~1.5 minutes for each run.
The caches are keyed by the python version and
pyproject.tomlfor JANUS and toSOCRATES/versionfor SOCRATES.I also scoped the test runs, so that they no longer run twice in a PR.
Closes #37
TODO
FWL_DATAdirectoryFWL_DATA