Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run janus #54

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Run janus #54

merged 4 commits into from
Aug 27, 2024

Conversation

lsoucasse
Copy link
Member

@lsoucasse lsoucasse commented Aug 26, 2024

This small PR adds utility functions to the atmospheric module to update the state of the atmosphere object. This will help clarifying the PROTEUS atmospheric wrapper.

@lsoucasse lsoucasse linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some minor suggestions on the code style.

If possible, it could be a good opportunity to add some tests for these methods.

src/janus/utils/atmosphere_column.py Outdated Show resolved Hide resolved
src/janus/utils/atmosphere_column.py Outdated Show resolved Hide resolved
src/janus/utils/atmosphere_column.py Outdated Show resolved Hide resolved
@lsoucasse
Copy link
Member Author

Thanks @stefsmeets. Unit tests would probably make sense for these methods. For now I tested them through proteus.

@lsoucasse lsoucasse merged commit a5444ae into master Aug 27, 2024
3 checks passed
@lsoucasse lsoucasse deleted the run-janus branch August 27, 2024 09:53
lsoucasse added a commit that referenced this pull request Sep 24, 2024
* Add set state functions for atmosphere object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide "run" Janus functions
2 participants