Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GIF editing? #147

Closed
chadoh opened this issue Nov 27, 2017 · 4 comments
Closed

Prevent GIF editing? #147

chadoh opened this issue Nov 27, 2017 · 4 comments

Comments

@chadoh
Copy link
Contributor

chadoh commented Nov 27, 2017

It's currently possible for any member of a community to edit the caption and nickname associated with a GIF. I think it might be better to have those attributes be totally uneditable, rather than group-editable. @s-small and @AquiGorka, what do y'all think?

@AquiGorka
Copy link
Contributor

I did bring this up some time ago, we either:

  1. Attributes uneditable
  2. Attributes editable <- by everyone
  3. Add a user/owner layer on top of content and only the creator can edit <- hard

If we decide to go with 1 there isn't that much to change, the data itself will still be requested via the info from the YJS room either way. Meaning, if we want this, it can be as easy as removing the Editable component and everything else stays as is.

Maybe 3 isn't that difficult, I'll research on it when I have some time. Maybe YJS already has something implemented. I know Orbit does, they even have a user/admin layer.

I like 2. Everyone is responsible for the community, their resources (sharing disk space) and curating the content.

@chadoh
Copy link
Contributor Author

chadoh commented Nov 28, 2017

Your 3 sounds like #48. We can circle back to that.

I am ok with 1 and 2. Right now we are using 2. I just wanted to make sure that we had a conversation about the trade-offs, and make sure we are all on board with the direction we take. @s-small what do you think?

@s-small
Copy link

s-small commented Nov 29, 2017

@chadoh @AquiGorka I think for the sake of simplicity 2 sounds like it makes the most sense. We definitely want the user themselves to be able to edit their own nickname and gif titles. Gets a little weird when other users are editing another user's nickname/gif titles, but that may be fine for now and we just have to trust that users will be respectful of one another. Definitely think the end goal would be 3 or some variation though.

@chadoh
Copy link
Contributor Author

chadoh commented Nov 29, 2017

Cool, then I'll close this.

@chadoh chadoh closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants