You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to run yarn build successfully we needed to remove the minify step from the build process. We need to be able to integrate it back to minify our code deployed to production.
tldr;
create-react-app uses uglify 2 and some of our dependencies (mostly from IPFS) where throwing an error when minifying (their codebase is built with es6 syntax and uglify 2 is not able to understand it).
By transpiling their code base before minifying we hoped the process would succeed, and it did, but another error popped up. This error is referenced here. Seems their library checks against class names. minify libraries overwrite class names thus the check fails.
Tried using uglify 3 since it understands es6 syntax but the name checking error still renders and the app does not work. Even with the keep_fnames: true and keep_classnames configuration params the app fails (the error is no longer about the classname but another one: Uncaught SyntaxError: Unexpected token ().
Tried using babili with the keepFnNames & keepClassName params and it did not work either.
The text was updated successfully, but these errors were encountered:
Ref: here
In order to run
yarn build
successfully we needed to remove the minify step from the build process. We need to be able to integrate it back to minify our code deployed to production.tldr;
create-react-app
usesuglify 2
and some of our dependencies (mostly from IPFS) where throwing an error when minifying (their codebase is built withes6
syntax anduglify 2
is not able to understand it).class
names.minify
libraries overwrite class names thus the check fails.uglify 3
since it understandses6
syntax but the name checking error still renders and the app does not work. Even with thekeep_fnames: true
andkeep_classnames
configuration params the app fails (the error is no longer about the classname but another one:Uncaught SyntaxError: Unexpected token (
).babili
with thekeepFnNames
&keepClassName
params and it did not work either.The text was updated successfully, but these errors were encountered: