Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted sundays #65

Open
5 tasks done
iBabu007 opened this issue Jan 12, 2024 · 4 comments
Open
5 tasks done

Highlighted sundays #65

iBabu007 opened this issue Jan 12, 2024 · 4 comments
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up

Comments

@iBabu007
Copy link
Contributor

iBabu007 commented Jan 12, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Highlighted Sunday is more important
than highlighted weekend.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Please add a highlighted Sundays option under highlighted weekend.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@iBabu007 iBabu007 added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 12, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 12, 2024

I think it will be redundant. I've never seen a calendar app that highlights specifically Sundays, always the whole weekend. Another thing is, that if Sunday is more important depends on a culture, it's not a universal thing.

@ikazuhiro
Copy link
Contributor

Highlighting Saturday and Sunday in different color is very popular in Japan. Many calendar applications made in Japan highlight Sunday with red and Saturday with blue as printed one in Japan, e.g. Jorte and Lifebear.
Of course, it is not a universal thing. But we are happy if you are interested in other's culture and would consider to provide more customizable weekends highlight feature. I could send PR to enable highlight Saturday in different color.

Cf. Rejected PR for Simple Calendar

@Aga-C
Copy link
Member

Aga-C commented Jan 15, 2024

I could send PR to enable highlight Saturday in different color.

When needs triage label is taken off this issue, you're free to create a PR.

@naveensingh
Copy link
Member

We can modify the "Highlight weekends" switch preference to show a dialog with the following options:

  • Friday
  • Saturday
  • Sunday

Thursday could also be there as per the wiki but I like three options more.

Highlighting the weekends in different colors would complicate things further and should be a separate issue.

@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

4 participants