Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files deleted by renaming when a rename pattern includes '/' #47

Closed
7 tasks done
Roccobot opened this issue Jan 31, 2024 · 2 comments
Closed
7 tasks done

Files deleted by renaming when a rename pattern includes '/' #47

Roccobot opened this issue Jan 31, 2024 · 2 comments
Labels
bug Something is not working

Comments

@Roccobot
Copy link

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.1

Affected Android/Custom ROM version

Realme UI 4.0 Official / RMX3363_13.1.0.158(EX01), Android 13

Affected device model

Realme GT Master

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Select some files
  2. Tap the 'Rename' button
  3. Type the new name template, including a / (not as the last character)
  4. Tap 'OK' to rename
  5. Grant permission to handle files (this does not happen every time)

Expected behavior

The files are renamed

Actual behavior

Two (apparently random) outcomes:

• Only one of the files remain, and its new name is just the part of the pattern after /. All the other files are permanently deleted.

• An exception/unknown error message appears. After a refresh, all the files are permanently gone.

Screenshots/Screen recordings

No response

Additional information

No response

@Roccobot Roccobot added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 31, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 31, 2024
@min7-i
Copy link

min7-i commented Feb 2, 2024

To add a few more details: Using the simple renaming method, the app correctly displays a toast message The name contains invalid characters when the string contains /.
Using the pattern method, the app, however, displays an error message:
pattern_rename_error

After cancelling the dialog and refreshing the file list all but one of the files to be renamed have disappeared.

(Tested on devices with Android 9 and Android 14.)

@naveensingh
Copy link
Member

Should be fixed in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants