Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua error add filepath to error message #4931

Closed
frskyrc-ben opened this issue Dec 27, 2024 · 6 comments
Closed

Lua error add filepath to error message #4931

frskyrc-ben opened this issue Dec 27, 2024 · 6 comments
Labels

Comments

@frskyrc-ben
Copy link

frskyrc-ben commented Dec 27, 2024

When a lua script is outdated (or missing) and throws a system error such as "Lua widget key '' not found", it will be really helpful to have the file path of the script which is causing the error (or widget filepath that is missing)

Clipped_image_20241226_161114

Right now we can only tell people to delete the lua scripts one by one until the error goes away, and then to put them back on the radio except for the one which causes the error

This is a terrible way for people to have to deal with these errors.

Additionally we should consider to add a "Disable script" option to the error which can automatically disable the lua script by moving into a separate folder such as radio:/scripts_disabled

These errors are particularly frustrating to users after new ETHOS updates since they don't know which script is causing the error

@bsongis-frsky
Copy link
Collaborator

This is difficult, as the script is not there!

@frskyrc-ben
Copy link
Author

This is difficult, as the script is not there!

can it be read from the widget settings in screen configuration ?

IE, if screen 2 has widget looking for radio:\scripts\some_widget and this doesn't exist, then it can reference this screen or exact widget ? like "Screen2 Widget <some_widget> not found"

@bsongis
Copy link
Contributor

bsongis commented Jan 2, 2025

Not exacly, Screen2, Widget 1 will use the script with the key "mylua", but it doesn't know which is the script which exports this key!

@frskyrc-ben
Copy link
Author

frskyrc-ben commented Jan 2, 2025

Oh, I see. Well it may still be helpful to have the key name displayed by the error, and so long that the key name is unique for the widget, the user should be able to know which lua script is missing and which they need to reinstall

I'm just trying to find some way to make the error messages more user friendly because during several updates this has been a common issue that many users will post or ask about the various lua errors

@bsongis-frsky
Copy link
Collaborator

Right the key should be displayed. I will check it is. On your screenshot it seems empty!

@bsongis-frsky bsongis-frsky added this to the 1.6.1 milestone Jan 7, 2025
@bsongis-frsky
Copy link
Collaborator

Yes the missing key is displayed properly in the error message!

image

@bsongis-frsky bsongis-frsky removed this from the 1.6.1 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants