Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Shortcut key for "Toggle Loop" #4298

Closed
3 tasks done
shadycloud opened this issue Nov 8, 2023 · 2 comments
Closed
3 tasks done

[Feature Request]: Shortcut key for "Toggle Loop" #4298

shadycloud opened this issue Nov 8, 2023 · 2 comments

Comments

@shadycloud
Copy link

shadycloud commented Nov 8, 2023

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Much like, [Feature Request]: Keyboard shortcut to toggle autoplay #4103,
At this moment a shortcut for the Toggle Loop button is not part of the media player.

Proposed Solution

A keyboard shortcut for the "Toggle Loop" video player button "R" or "r" (mnemonic for replay)

"L" or "l" for "Loop" wont work since it's already used...
https://docs.freetubeapp.io/usage/keyboard-shortcuts/

Alternatives Considered

NA

Issue Labels

display more information to user, ease of use improvement, improvement to existing feature, new keyboard shortcut, visual improvement

@shadycloud
Copy link
Author

@Hector118, @fdarcey, @ubello64, @KSterner2, and I got this feature working yesterday on a machine but it was with version 0.19.0... Was going to put in a pull request this morning so we can be closer to having a shortcut for every player button, in turn closing #1587 However, Toggle Loop seems to be in a state of flux using fresh clone w/ Ubuntu 22.04, because I get the following error message. Was going to make a bug report, but the Toggle Loop feature is working on the latest github release I just tested.

case 'R':
case 'r':
  event.preventDefault()
  this.toggleVideoLoop()
  break

Screenshot from 2023-11-10 09-57-12

video.es.js:229 VIDEOJS: ERROR: TypeError: Cannot read properties of undefined (reading 'value')
    at VueComponent.toggleVideoLoop (ft-video-player.js:1450:1)
    at loopButton.handleClick (ft-video-player.js:1424:1)
    at ClickableComponent._this.handleClick_ (video.es.js:10585:1)
    at data.dispatcher (video.es.js:2312:1) ```

@shadycloud
Copy link
Author

Closing for same reason as #4227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant