Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show on hover if icon has shortcut #1587

Open
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Aug 14, 2021 · 3 comments · May be fixed by #5857
Open

Show on hover if icon has shortcut #1587

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Aug 14, 2021 · 3 comments · May be fixed by #5857
Assignees
Labels
enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Is your feature request related to a usage problem (not a bug)? Please describe.
I often go back to the docs because i need to find out what shortcut i need for a task. This wont be the case if i can look it up fast on just a hover.

Describe the solution you'd like to see implemented
See video. This also needs to be the case when the rewrite is done and u can choose ur own shortcuts.

Describe alternatives you've considered
None.

Video

dwzyS8MNlF.mp4

Additional context
None.

@vallode
Copy link
Contributor

vallode commented Mar 23, 2022

Spent some time looking into this, sadly it's not as easy as I thought it ought to be. Videojs doesn't provide a direct way of changing the buttons' labels (and most of them are dynamically changing) so for a clean way of changing this I think we'd need to extend every single (around 15) of the Videojs buttons we use.

When/if I am bored I'll get this done because I'd like to see it too ;)

@kommunarr
Copy link
Collaborator

Boosting this issue / keeping it in mind for any possible future shakaup.

@shadycloud
Copy link

shadycloud commented Nov 8, 2023

Screenshot from 2023-11-12 15-48-58

From left to right the respective to the player...
Skipping the buttons with multiple options (like quality, captions, and playback speed)
I am having a hard time grepping for a few of them. (i.e. Play, Pause, Replay, Mute, Pic in Pic, and Full Screen)

Play (Shortcut 'Space Bar')
Pause (Shortcut 'Space Bar')
Replay (NA)
Mute (Shortcut 'M' or 'm')
Toggle Loop (N/A) #4298
Picture-in-Picture (Shortcut 'I' or 'i')
Full Window (Shortcut 'S' or 's')
Full Screen (Shortcut 'F' or 'f')

cloud@cloud:~/FreeTube$ grep -r "button.title"
grep: src/renderer/components/ft-video-player/.ft-video-player.js.swo: binary file matches
src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Toggle Loop'
src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Full Window' 
src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Toggle Theatre Mode'
src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Screenshot'
src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Select Quality'

replaced by the following to at least show the shortcut on hover of full window and toggle loop buttons...

src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Full Window (Shortcut S or s)'
src/renderer/components/ft-video-player/ft-video-player.js:          button.title = 'Toggle Loop (Shortcut R or r)'

shadycloud added a commit to shadycloud/FreeTubeKS that referenced this issue Nov 10, 2023
@kommunarr kommunarr added the player-related Player-related changes are currently on hold due to the ongoing player migration. label Apr 17, 2024
@kommunarr kommunarr self-assigned this Oct 13, 2024
@kommunarr kommunarr linked a pull request Oct 13, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.
Projects
Status: Medium Priority
Development

Successfully merging a pull request may close this issue.

4 participants