-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show on hover if icon has shortcut #1587
Show on hover if icon has shortcut #1587
Comments
Spent some time looking into this, sadly it's not as easy as I thought it ought to be. Videojs doesn't provide a direct way of changing the buttons' labels (and most of them are dynamically changing) so for a clean way of changing this I think we'd need to extend every single (around 15) of the Videojs buttons we use. When/if I am bored I'll get this done because I'd like to see it too ;) |
Boosting this issue / keeping it in mind for any possible future shakaup. |
From left to right the respective to the player... Play (Shortcut 'Space Bar')
replaced by the following to at least show the shortcut on hover of full window and toggle loop buttons...
|
Is your feature request related to a usage problem (not a bug)? Please describe.
I often go back to the docs because i need to find out what shortcut i need for a task. This wont be the case if i can look it up fast on just a hover.
Describe the solution you'd like to see implemented
See video. This also needs to be the case when the rewrite is done and u can choose ur own shortcuts.
Describe alternatives you've considered
None.
Video
dwzyS8MNlF.mp4
Additional context
None.
The text was updated successfully, but these errors were encountered: