-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Play All and Shuffle Button #6153
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good but i did notice this error when entering an empty playlist.
VirtualBoxVM_l8o7eOKNHE.mp4
Head branch was pushed to by a user without write access
I have fixed this error and I have hid the buttons when the playlist is empty. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking): I'd ideally like it if on a desktop view breakpoint for the grid view playlist page, the top row became a flex container with the icons on the left and the new buttons on the right. This way the fixed container wouldn't have to be as tall.
discussion: I do also think that all of our icons should have visible labels, not just these two, for accessibility & ease of use reasons. That said, that's no reason to not have them here, just that in the future I recommend that all of these buttons become of the same type, with optionally the same positioning differences kept if we feel like it.
This is a signal boost for #4950 and i like the member to chime in on that PR. I think it would be a good improvement. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Head branch was pushed to by a user without write access
Thoughts: Playlist Grid view: To it seems a bit weird that the Secondary color theme colors are divided by the red icons. Maybe place the buttons to the left of the bookmark icon so that its grouped by color? Channel playlist view: Would maybe look nicer if the buttons are placed to the left of the copy and share link buttons Playlist List view: The suggestion above cant be applied here as there isnt space for it. I do think that it kind of looks off when sitting between the icons above and the searchbar but im not sure if it can be made to look 'nicer' |
Add Play All and Shuffle Button
Pull Request Type
Related issue
#5618
Description
Added
Play all
andShuffle
buttons to both user and youtube playlists.Clicking on
Play all
always plays the first video in the playlist.Clicking on
Shuffle
plays a random video in the playlist and toggles shuffle mode on.Screenshots
Before
User Playlist
Youtube Playlist
After
User Playlist
Youtube Playlist
Testing
Play all
plays the first video after video order is changed.Shuffle
works as intended after a video is deleted whilst playing through the playlist.Shuffle
resets the playlist after adding a new video whilst it is playing its last item in the iteration. This behaviours is inherited from the development branch.Desktop
Additional context