Add setting for opening freetube:// links in new window

[OothecaPickle]

Add setting for opening freetube:// links in new window

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #1501
also relates to #6237

Description

Adds a toggle under General Settings to open freetube:// links in a new window rather than replacing the contents of an existing window.

Screenshots

Testing

Test that freetube:// links opened from other applications are opened in a new window when the added setting is toggled on.

Desktop

• OS: macOS
• OS Version: 11
• FreeTube version: e646a0f
  &
• OS: Windows
• OS Version: Windows 10 21H2
• FreeTube version: e646a0f

Additional context

I used some code from @pakoito's #5592.

[PikachuEXE]

Are you talking about https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app#overview ?
Maybe the preference name should be updated first

Also I am not sure how/if the doc mentions deep links and if users understand what is freetube:// links

[OothecaPickle]

@PikachuEXE

Are you talking about https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app#overview ?

Yes.

Maybe the preference name should be updated first
Also I am not sure how/if the doc mentions deep links and if users understand what is freetube:// links

I agree, but I wasn't sure what else to name it. Do you have any suggestions?

[PikachuEXE]

I found one place mentioning extensions but not sure how to call it
https://docs.freetubeapp.io/usage/browser-extension/

It shouldn't be called "YouTube links" on the preference coz there are many "YT" links in video description/comment etc.

Inviting more members to comment on this

[pakoito]

In Android land these are called "Intents" rather than "Links". But tbh I'd be sad if this feature is blocked on a label :D

[absidue]

Please use two separate parameters instead of using a single parameter with an object, that lets you avoid the destructuring on the other end.