From d75aaaf6f51912bbb97ce09e51941809d6be0303 Mon Sep 17 00:00:00 2001 From: Alex Li Date: Wed, 29 Mar 2023 16:11:18 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A8=20Analyze=20repos=20with=20fatal?= =?UTF-8?q?=20infos=20(#1773)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/tests.yml | 4 ++-- plugins/http2_adapter/lib/src/connection_manager_imp.dart | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ac847903b..cc99ae394 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -53,7 +53,7 @@ jobs: with: sdk: stable - name: Analyze - run: dart pub get && dart analyze + run: dart pub get && dart analyze --fatal-infos analyze_flutter: needs: format @@ -73,7 +73,7 @@ jobs: cache: true channel: stable - name: Analyze - run: flutter pub get && flutter analyze + run: flutter pub get && flutter analyze --fatal-infos test_dio: needs: [analyze, analyze_flutter] diff --git a/plugins/http2_adapter/lib/src/connection_manager_imp.dart b/plugins/http2_adapter/lib/src/connection_manager_imp.dart index 359679c61..2b9d1af22 100644 --- a/plugins/http2_adapter/lib/src/connection_manager_imp.dart +++ b/plugins/http2_adapter/lib/src/connection_manager_imp.dart @@ -169,7 +169,7 @@ class _ConnectionManager implements ConnectionManager { final completerProxyInitialization = Completer(); - Never _onProxyError(Object? error, StackTrace stackTrace) { + Never onProxyError(Object? error, StackTrace stackTrace) { throw DioError( requestOptions: options, error: error, @@ -178,7 +178,7 @@ class _ConnectionManager implements ConnectionManager { ); } - completerProxyInitialization.future.onError(_onProxyError); + completerProxyInitialization.future.onError(onProxyError); final proxySubscription = proxySocket.listen( (event) {