Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos won't continue, always start from beginning #31

Open
schnills opened this issue Dec 20, 2021 · 9 comments
Open

Videos won't continue, always start from beginning #31

schnills opened this issue Dec 20, 2021 · 9 comments

Comments

@schnills
Copy link

Hey,
first of all: thanks for using YouTube usable at all again. It became unbearable and your app has even better features than premium (sponsor skipping etc).
Only one issue that's a bit annoying: It doesn't save where I stopped a video. It always displays a seen video with the red bar at the beginning at always starts from there. So I can't really continue where I stopped but have to remember where that was.
I mean, this is a relatively small trade off for the otherwise great features you provide. I'd always choose this over ads every three minutes.
Still maybe you can improve this in the future :)

Another thing you might find interesting is how I keep developer mode active without root. I've described it here:
https://forum.xda-developers.com/t/developer-mode-extend-session-time.4012841/

Thanks for your great work.

@Informatic
Copy link
Contributor

Informatic commented Dec 20, 2021

Have you tried disabling adblocking and see if that works again? We are definitely overeager with requests we block (one such is ptracking) - after removing that / disabling adblocking that request (and playback progress requests) are properly sent, but I wasn't able to make the player actually start from the last played timestamp. "Normal" YouTube running on a separate computer with the same Google account signed in did properly start from a proper timestamp last played on YouTube TV (adfree).

Which webOS version are you on? 4.x+? The way we launch youtube is similar to what was done on 3.x and older. (running in WebAppManager, instead of Cobalt) Maybe launching from a proper timestamp is just broken on older browsers.

Reference webosbrew#4 - same issue.

Debugging note:
Start timestamp is sent in response to POST https://www.youtube.com/youtubei/v1/player, key playerConfig.playbackStartConfig.startSeconds. Tested in Firefox with User-Agent set to 2021 webOS user-agent..

@schnills
Copy link
Author

Thanks for the quick response, man!
Disabling adblocking indeed made it working again. It continued at the corresponding timestamp. After enabling adblocking again, no new timestamp was saved - the old one from having adblocking disabled is still active.

I'm on WebOS 4.30.40.
In the reference you posted I saw a test ipk. I'll probably give it a try tomorrow.

Btw, I just upgraded from youtube adfree v4_0.1.0 (or .1.1) to v4_0.2.0 and realized the settings have been reduced. I kept them all on anyway, but any specific reason to reduce them only to ad and sponsor blocking?
I could imagine some people would like to have more options about intro/outro skipping and such.

@Informatic
Copy link
Contributor

Informatic commented Dec 20, 2021

Not sure which version you are talking about. 0.2.0 was never released. Settings menu should look exactly like this: https://github.com/webosbrew/youtube-webos#readme
If you actually downloaded that test .ipk and it's missing, then that's definitely a bug (I didn't notice on my TV during testing)

@schnills
Copy link
Author

Uhm no, I actually downloaded it from your repository
image

@schnills
Copy link
Author

I just stumbled across it yesterday and thought it's new public version

@Informatic
Copy link
Contributor

Nope, that's a gross misunderstanding, sorry. I was just testing out github releases on my fork a month or so ago. :D
Test release I mentioned can be downloaded here: https://github.com/webosbrew/youtube-webos/actions/runs/1603263259

@schnills
Copy link
Author

Ah okay :D
Sorry for keeping you waiting, but I could test it now and it seems to work just fine, which is great.
Thanks so much :)

@Informatic
Copy link
Contributor

Great. A version with this (and a couple other fixes) has been released in webosbrew fork/repo.

@strdik
Copy link

strdik commented Dec 29, 2021

I like this YouTube, but it is impossible to watch when it does not save the video, please, if you read this comment, check everything properly, fix the errors and make sure that the video is saved at the place where it stopped now, version 0.2.1 is standing, I hope for you and happy New Year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants