diff --git a/.phive/phars.xml b/.phive/phars.xml index d311bfa5..eaf11a6b 100644 --- a/.phive/phars.xml +++ b/.phive/phars.xml @@ -1,5 +1,5 @@ - + diff --git a/composer.json b/composer.json index 3ade071b..4c3866f8 100644 --- a/composer.json +++ b/composer.json @@ -17,12 +17,12 @@ } ], "require": { - "cakephp/cakephp": "^5.0" + "cakephp/cakephp": "^5.1" }, "require-dev": { - "phpunit/phpunit": "^10.1", + "phpunit/phpunit": "^10.5.5 || ^11.1.3", "cakephp/bake": "^3.0", - "cakephp/cakephp-codesniffer": "^5.0" + "cakephp/cakephp-codesniffer": "^5.1" }, "support": { "issues": "http://github.com/friendsofcake/bootstrap-ui/issues", diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php index b7d5c6ab..fd70b572 100644 --- a/src/View/Helper/FormHelper.php +++ b/src/View/Helper/FormHelper.php @@ -146,15 +146,6 @@ class FormHelper extends CoreFormHelper '', 'formGroupFloatingLabel' => '{{input}}{{label}}', - 'datetimeContainer' => - '{{content}}{{help}}', - 'datetimeContainerError' => - '' . - '{{content}}{{error}}{{help}}', - 'datetimeLabel' => - '{{text}}{{tooltip}}', 'inputContainer' => '{{content}}{{help}}', @@ -242,16 +233,6 @@ class FormHelper extends CoreFormHelper '{{content}}{{error}}{{help}}', - 'datetimeContainer' => - '' . - '{{content}}{{help}}', - 'datetimeContainerError' => - '' . - '{{content}}{{error}}{{help}}', - 'datetimeLabel' => - '{{text}}{{tooltip}}', 'radioContainer' => '{{input}}{{label}}{{error}}{{help}}', 'checkboxFormGroup' => '
{{input}}{{label}}{{error}}{{help}}
', - 'datetimeContainer' => - '{{content}}', - 'datetimeContainerError' => - '' . - '{{content}}', - 'datetimeLabel' => - '{{text}}{{tooltip}}', 'checkboxInlineFormGroup' => '
{{input}}{{label}}
', 'submitContainer' => @@ -350,13 +322,6 @@ class FormHelper extends CoreFormHelper '_default' => 'BootstrapUI\View\Widget\BasicWidget', ]; - /** - * The name of the field for which the current error is being generated. - * - * @var string|null - */ - private ?string $_errorFieldName = null; - /** * {@inheritDoc} * @@ -414,40 +379,6 @@ public function create(mixed $context = null, array $options = []): string return parent::create($context, $this->_processFormOptions($options)); } - /** - * @inheritDoc - */ - public function error(string $field, array|string|null $text = null, array $options = []): string - { - $this->_errorFieldName = $field; - $error = parent::error($field, $text, $options); - $this->_errorFieldName = null; - - return $error; - } - - /** - * @inheritDoc - */ - public function formatTemplate(string $name, array $data): string - { - // Injects the `id` attribute value for the error template. - // This is done for backwards compatibility reasons, as the - // core form helper only introduced this behavior with - // CakePHP 4.3. This can be removed once the required minimum - // CakePHP version is bumped accordingly. - - if ( - $name === 'error' && - !isset($data['id']) && - $this->_errorFieldName !== null - ) { - $data['id'] = $this->_domId($this->_errorFieldName . '-error'); - } - - return parent::formatTemplate($name, $data); - } - /** * @inheritDoc */ @@ -548,13 +479,6 @@ public function control(string $fieldName, array $options = []): string } switch ($options['type']) { - case 'datetime-local': - case 'datetime': - case 'date': - case 'time': - $options = $this->_dateTimeOptions($fieldName, $options); - break; - case 'checkbox': case 'radio': case 'select': @@ -676,35 +600,6 @@ protected function _containerOptions(?string $fieldName, array $options): array return $options; } - /** - * Modify options for date time controls. - * - * @param string $fieldName Field name. - * @param array $options Options. See `$options` argument of `control()` method. - * @return array - */ - protected function _dateTimeOptions(string $fieldName, array $options): array - { - $options = $this->_labelOptions($fieldName, $options); - - // group IDs are no longer required for date/time controls, - // this is just kept for backwards compatibility - - $groupId = - $options['templateVars']['groupId'] = - $this->_domId($fieldName . '-group-label'); - - if ($options['label'] !== false) { - $options['label']['templateVars']['groupId'] = $groupId; - } - - $options['templates']['label'] = $this->templater()->get('datetimeLabel'); - $options['templates']['inputContainer'] = $this->templater()->get('datetimeContainer'); - $options['templates']['inputContainerError'] = $this->templater()->get('datetimeContainerError'); - - return $options; - } - /** * Modify options for checkbox controls. * @@ -985,8 +880,8 @@ protected function _ariaOptions(string $fieldName, array $options): array { if ( $options['type'] === 'hidden' || + ($options['type'] === 'select' && isset($options['multiple']) && $options['multiple'] === 'checkbox') || ( - isset($options['aria-required']) && isset($options['aria-describedby']) && isset($options['aria-invalid']) ) @@ -998,12 +893,8 @@ protected function _ariaOptions(string $fieldName, array $options): array $options['error'] !== false && $this->isFieldError($fieldName); - // `aria-invalid` and `aria-required` are injected for backwards - // compatibility reasons, as support for this has only been - // introduced in the core form helper with CakePHP 4.3. This can - // be removed once the required minimum CakePHP version is bumped - // accordingly. - + // This is required because of a bug in CakePHP 5 due to which + // `aria-invalid` is not applied for `select` tags. if ( $isError && !isset($options['aria-invalid']) @@ -1011,13 +902,6 @@ protected function _ariaOptions(string $fieldName, array $options): array $options['aria-invalid'] = 'true'; } - if ( - $options['required'] && - !isset($options['aria-required']) - ) { - $options['aria-required'] = 'true'; - } - if (isset($options['aria-describedby'])) { return $options; } @@ -1435,10 +1319,6 @@ protected function _processFormOptions(array $options): array $templates['label'], $this->_gridClass(static::GRID_COLUMN_ONE) ); - $templates['datetimeLabel'] = sprintf( - $templates['datetimeLabel'], - $this->_gridClass(static::GRID_COLUMN_ONE) - ); $templates['radioLabel'] = sprintf( $templates['radioLabel'], $this->_gridClass(static::GRID_COLUMN_ONE) diff --git a/tests/TestCase/Bake/BakeTest.php b/tests/TestCase/Bake/BakeTest.php index f2f9520f..4a07d12b 100644 --- a/tests/TestCase/Bake/BakeTest.php +++ b/tests/TestCase/Bake/BakeTest.php @@ -26,12 +26,6 @@ public function setUp(): void parent::setUp(); $this->_compareBasePath = Plugin::path('BootstrapUI') . 'tests' . DS . 'comparisons' . DS . 'Template' . DS; - - $this->loadPlugins([ - 'Cake/TwigView' => [ - 'bootstrap' => true, - ], - ]); } public function tearDown(): void diff --git a/tests/TestCase/Command/InstallCommandTest.php b/tests/TestCase/Command/InstallCommandTest.php index d88bd324..113648bd 100644 --- a/tests/TestCase/Command/InstallCommandTest.php +++ b/tests/TestCase/Command/InstallCommandTest.php @@ -574,12 +574,12 @@ public function testNPMInstallFailure() $command ->expects($this->once()) ->method('_runNPMInstall') - ->will($this->returnCallback(function (&$out, &$return) { + ->willReturnCallback(function (&$out, &$return) { $out = [ 'installer output', ]; $return = 1234; - })); + }); $out = new StubConsoleOutput(); $err = new StubConsoleOutput(); diff --git a/tests/TestCase/View/Helper/FlashHelperTest.php b/tests/TestCase/View/Helper/FlashHelperTest.php index 30f899dc..55ee5c1b 100644 --- a/tests/TestCase/View/Helper/FlashHelperTest.php +++ b/tests/TestCase/View/Helper/FlashHelperTest.php @@ -8,6 +8,7 @@ use Cake\Http\Session; use Cake\TestSuite\TestCase; use Cake\View\View; +use PHPUnit\Framework\Attributes\DataProvider; use UnexpectedValueException; /** @@ -63,11 +64,11 @@ public static function flashTypeDefaultsDataProvider(): array } /** - * @dataProvider flashTypeDefaultsDataProvider * @param string $type The flash type. * @param string $class The alert class. * @param string $icon The icon name. */ + #[DataProvider('flashTypeDefaultsDataProvider')] public function testRenderDefaults(string $type, string $class, string $icon) { $this->View->getRequest()->getSession()->write('Flash', [ @@ -445,9 +446,9 @@ public static function flashTypeDataProvider(): array } /** - * @dataProvider flashTypeDataProvider * @param string $type The flash type. */ + #[DataProvider('flashTypeDataProvider')] public function testCustomDefaultIcon(string $type) { $this->Flash->setConfig('icon', 'info'); @@ -466,9 +467,9 @@ public function testCustomDefaultIcon(string $type) } /** - * @dataProvider flashTypeDataProvider * @param string $type The flash type. */ + #[DataProvider('flashTypeDataProvider')] public function testDisableIconsViaConfig(string $type) { $this->Flash->setConfig('icon', false); @@ -490,6 +491,7 @@ public function testDisableIconsViaConfig(string $type) * @dataProvider flashTypeDataProvider * @param string $type The flash type. */ + #[DataProvider('flashTypeDataProvider')] public function testDisableIconViaParamsOption(string $type) { $this->View->getRequest()->getSession()->write('Flash', [ @@ -508,9 +510,9 @@ public function testDisableIconViaParamsOption(string $type) } /** - * @dataProvider flashTypeDataProvider * @param string $type The flash type. */ + #[DataProvider('flashTypeDataProvider')] public function testCustomIconClassMap(string $type) { $iconClassMap = [ @@ -540,9 +542,9 @@ public function testCustomIconClassMap(string $type) } /** - * @dataProvider flashTypeDataProvider * @param string $type The flash type. */ + #[DataProvider('flashTypeDataProvider')] public function testCustomIconClassMapOptions(string $type) { $options = [ diff --git a/tests/TestCase/View/Helper/FormHelper/DefaultAlign/DateTimeControlTest.php b/tests/TestCase/View/Helper/FormHelper/DefaultAlign/DateTimeControlTest.php index fd2099b8..8800655b 100644 --- a/tests/TestCase/View/Helper/FormHelper/DefaultAlign/DateTimeControlTest.php +++ b/tests/TestCase/View/Helper/FormHelper/DefaultAlign/DateTimeControlTest.php @@ -559,24 +559,24 @@ public function testDefaultAlignDateTimeControlCustomContainerTemplateViaTemplat $this->assertStringContainsString('
', $result); $this->Form->setTemplates([ - 'datetimeContainer' => '
{{content}}
', - 'dateContainer' => '
{{content}}
', - 'timeContainer' => '
{{content}}
', + 'datetimeContainer' => '
{{content}}
', + 'dateContainer' => '
{{content}}
', + 'timeContainer' => '
{{content}}
', ]); $result = $this->Form->control('created', [ 'type' => 'datetime', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); } public function testDefaultAlignDateTimeControlCustomContainerErrorTemplateViaOptions() @@ -606,25 +606,25 @@ public function testDefaultAlignDateTimeControlCustomContainerErrorTemplateViaOp $result = $this->Form->control('created', [ 'type' => 'datetime', 'templates' => [ - 'datetimeContainerError' => '
{{content}}
', + 'datetimeContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', 'templates' => [ - 'dateContainerError' => '
{{content}}
', + 'dateContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', 'templates' => [ - 'timeContainerError' => '
{{content}}
', + 'timeContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); } } diff --git a/tests/TestCase/View/Helper/FormHelper/HorizontalAlign/DateTimeControlTest.php b/tests/TestCase/View/Helper/FormHelper/HorizontalAlign/DateTimeControlTest.php index 291f6304..a95e19d8 100644 --- a/tests/TestCase/View/Helper/FormHelper/HorizontalAlign/DateTimeControlTest.php +++ b/tests/TestCase/View/Helper/FormHelper/HorizontalAlign/DateTimeControlTest.php @@ -682,24 +682,24 @@ public function testHorizontalAlignDateTimeControlCustomContainerTemplateViaTemp $this->assertStringContainsString('
', $result); $this->Form->setTemplates([ - 'datetimeContainer' => '
{{content}}
', - 'dateContainer' => '
{{content}}
', - 'timeContainer' => '
{{content}}
', + 'datetimeContainer' => '
{{content}}
', + 'dateContainer' => '
{{content}}
', + 'timeContainer' => '
{{content}}
', ]); $result = $this->Form->control('created', [ 'type' => 'datetime', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); } public function testHorizontalAlignDateTimeControlCustomContainerErrorTemplateViaOptions() @@ -736,25 +736,25 @@ public function testHorizontalAlignDateTimeControlCustomContainerErrorTemplateVi $result = $this->Form->control('created', [ 'type' => 'datetime', 'templates' => [ - 'datetimeContainerError' => '
{{content}}
', + 'datetimeContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', 'templates' => [ - 'dateContainerError' => '
{{content}}
', + 'dateContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', 'templates' => [ - 'timeContainerError' => '
{{content}}
', + 'timeContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); } } diff --git a/tests/TestCase/View/Helper/FormHelper/InlineAlign/DateTimeControlTest.php b/tests/TestCase/View/Helper/FormHelper/InlineAlign/DateTimeControlTest.php index 8673f25f..85569029 100644 --- a/tests/TestCase/View/Helper/FormHelper/InlineAlign/DateTimeControlTest.php +++ b/tests/TestCase/View/Helper/FormHelper/InlineAlign/DateTimeControlTest.php @@ -24,7 +24,7 @@ public function testInlineAlignDateTimeControl() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created', '/label', @@ -58,7 +58,7 @@ public function testInlineAlignDateTimeControlWithDisabledLabel() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], 'input' => [ 'type' => 'datetime-local', 'name' => 'created', @@ -89,7 +89,7 @@ public function testInlineAlignDateTimeControlWithCustomLabel() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Custom Label', '/label', @@ -127,7 +127,7 @@ public function testInlineAlignDateTimeControlWithCustomLabelOptions() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], ['label' => [ 'class' => 'custom-label-class form-label visually-hidden', 'foo' => 'bar', @@ -165,7 +165,7 @@ public function testInlineAlignDateTimeControlWithHelp() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created', '/label', @@ -208,7 +208,7 @@ public function testInlineAlignDateTimeControlWithHelpOptions() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created', '/label', @@ -250,7 +250,7 @@ public function testInlineAlignDateTimeControlWithTooltip() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative datetime-local']], + ['div' => ['class' => 'form-group datetime-local']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created ', 'span' => [ @@ -338,7 +338,7 @@ public function testInlineAlignDateTimeControlContainerOptions() ['div' => ['class' => 'col-auto']], ['div' => [ 'attribute' => 'container-attribute', - 'class' => 'container-class form-group position-relative datetime-local', + 'class' => 'container-class form-group datetime-local', ]], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created', @@ -526,7 +526,7 @@ public function testInlineAlignDateTimeControlDate() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative date']], + ['div' => ['class' => 'form-group date']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created', '/label', @@ -559,7 +559,7 @@ public function testInlineAlignDateTimeControlTime() ]); $expected = [ ['div' => ['class' => 'col-auto']], - ['div' => ['class' => 'form-group position-relative time']], + ['div' => ['class' => 'form-group time']], ['label' => ['class' => 'form-label visually-hidden', 'for' => 'created']], 'Created', '/label', @@ -588,37 +588,37 @@ public function testInlineAlignDateTimeControlCustomContainerTemplateViaTemplate $result = $this->Form->control('created', [ 'type' => 'datetime', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $this->Form->setTemplates([ - 'datetimeContainer' => '
{{content}}
', - 'dateContainer' => '
{{content}}
', - 'timeContainer' => '
{{content}}
', + 'datetimeContainer' => '
{{content}}
', + 'dateContainer' => '
{{content}}
', + 'timeContainer' => '
{{content}}
', ]); $result = $this->Form->control('created', [ 'type' => 'datetime', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); } public function testInlineAlignDateTimeControlCustomContainerErrorTemplateViaOptions() @@ -652,25 +652,25 @@ public function testInlineAlignDateTimeControlCustomContainerErrorTemplateViaOpt $result = $this->Form->control('created', [ 'type' => 'datetime', 'templates' => [ - 'datetimeContainerError' => '
{{content}}
', + 'datetimeContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'date', 'templates' => [ - 'dateContainerError' => '
{{content}}
', + 'dateContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); $result = $this->Form->control('created', [ 'type' => 'time', 'templates' => [ - 'timeContainerError' => '
{{content}}
', + 'timeContainerError' => '
{{content}}
', ], ]); - $this->assertStringContainsString('
', $result); + $this->assertStringContainsString('
', $result); } } diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php index 0996be03..a6f0707b 100644 --- a/tests/TestCase/View/Helper/FormHelperTest.php +++ b/tests/TestCase/View/Helper/FormHelperTest.php @@ -55,7 +55,6 @@ public function testRequiredTextControl() 'id' => 'title', 'class' => 'form-control', 'required' => 'required', - 'aria-required' => 'true', ], '/div', ]; @@ -85,7 +84,6 @@ public function testAddOnPrependedText() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -119,7 +117,6 @@ public function testAddOnPrependedTextMultiple() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -147,7 +144,6 @@ public function testAddOnAppendedText() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], 'span' => ['class' => 'input-group-text'], '@', @@ -178,7 +174,6 @@ public function testAddOnAppendedTextMultiple() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], ['span' => ['class' => 'input-group-text']], '$', @@ -215,7 +210,6 @@ public function testAddOnPrependedButton() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -254,7 +248,6 @@ public function testAddOnPrependedButtonMultiple() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -282,7 +275,6 @@ public function testAddOnAppendedButton() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], 'button' => ['type' => 'submit', 'class' => 'btn btn-secondary'], 'GO', @@ -318,7 +310,6 @@ public function testAddOnAppendedButtonMultiple() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], ['button' => ['type' => 'submit', 'class' => 'btn btn-secondary']], 'NO', @@ -355,7 +346,6 @@ public function testAddOnOptions() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -378,7 +368,6 @@ public function testAddOnOptions() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], 'span' => ['class' => 'input-group-text'], '@', @@ -419,7 +408,6 @@ public function testAddOnOptionsMultiple() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -446,7 +434,6 @@ public function testAddOnOptionsMultiple() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], ['span' => ['class' => 'input-group-text']], '$', @@ -725,7 +712,6 @@ public function testCustomGridWithConstantsConfig() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -761,7 +747,6 @@ public function testCustomGridWithBasicArrayConfig() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -809,7 +794,6 @@ public function testHorizontalFormCreateFromConfig() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', '/div', @@ -922,7 +906,6 @@ public function testTooltipWithDisabledLabel() 'oninput' => 'this.setCustomValidity('')', 'id' => 'title', 'class' => 'form-control', - 'aria-required' => 'true', ], '/div', ]; @@ -1353,7 +1336,6 @@ public function testPartiallyOverrideAriaAttributes() 'oninput' => 'this.setCustomValidity('')', 'class' => 'is-invalid form-control', 'required' => 'required', - 'aria-required' => 'true', 'aria-describedby' => 'custom', ], ['div' => ['id' => 'title-error', 'class' => 'ms-0 invalid-feedback']], diff --git a/tests/TestCase/View/Helper/Types/ClassesTest.php b/tests/TestCase/View/Helper/Types/ClassesTest.php index 901b5569..2223cc55 100644 --- a/tests/TestCase/View/Helper/Types/ClassesTest.php +++ b/tests/TestCase/View/Helper/Types/ClassesTest.php @@ -15,7 +15,6 @@ class ClassesTest extends TestCase * Test get elements * * @return void - * @covers \BootstrapUI\View\Helper\Types\Classes::values */ public function testGetElements() { diff --git a/tests/TestCase/View/Helper/Types/ElementTest.php b/tests/TestCase/View/Helper/Types/ElementTest.php index 461099de..22d352eb 100644 --- a/tests/TestCase/View/Helper/Types/ElementTest.php +++ b/tests/TestCase/View/Helper/Types/ElementTest.php @@ -15,7 +15,6 @@ class ElementTest extends TestCase * Test get elements * * @return void - * @covers \BootstrapUI\View\Helper\Types\Element::values */ public function testGetElements() {