implements container.formGroupClass parameter to pass or disable classes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s different from form-group to containers
ADmad
reviewed
Nov 18, 2024
src/View/Helper/FormHelper.php
Outdated
| unset($options['container']); | ||
|
|
||
| $options['templateVars']['formGroupClass'] = 'form-group'; |
There was a problem hiding this comment.
Suggested change
| $options['templateVars']['formGroupClass'] = 'form-group'; | |
| $options['templateVars']['formGroupClass'] ??= 'form-group'; |
This allows setting the template var directly too instead of the custom option.
There was a problem hiding this comment.
I simplify logic based on your suggestion.
|
Hmm.. Bootstrap 5.3 has dropped |
|
Actually they have been dropped since 5.0 https://getbootstrap.com/docs/5.0/migration/#forms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements container.formGroupClass parameter to pass or disable classes different from form-group to containers.
When defined complex fields that should have their own containers, now possible to assign the .form-group class at wrapper level, while the inner fields rendered by FriendsOfCake/bootstrap-ui would not have it.