Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the graph creators #171

Merged
merged 11 commits into from
Nov 24, 2024
Merged

Refactoring of the graph creators #171

merged 11 commits into from
Nov 24, 2024

Commits on Nov 1, 2024

  1. implemented a Factory design pattern for graph creators

    @Frix-x
    Frix-x committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d6016b5 View commit details
    Browse the repository at this point in the history

  2. factorized Klipper commands

    @Frix-x
    Frix-x committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cad15c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. first step of separation of computations vs plotters

    @Frix-x
    Frix-x committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    177319d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. second step of refactorization creators vs plotters

    @Frix-x
    Frix-x committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    316c811 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Simplify logical expression using De Morgan identities 

    Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
    @Frix-x @sourcery-ai
    Frix-x and sourcery-ai[bot] authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d67a901 View commit details
    Browse the repository at this point in the history

  2. Simplify logical expression using De Morgan identities 

    Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
    @Frix-x @sourcery-ai
    Frix-x and sourcery-ai[bot] authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0c52ee6 View commit details
    Browse the repository at this point in the history

  3. Replace mutable default logo position argument with None 

    Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
    @Frix-x @sourcery-ai
    Frix-x and sourcery-ai[bot] authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    167bcb3 View commit details
    Browse the repository at this point in the history

  4. inline computation results in the return statement directly

    @Frix-x
    Frix-x committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e7f3180 View commit details
    Browse the repository at this point in the history

  5. using union operator for the graph creators parameters

    @Frix-x
    Frix-x committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5185715 View commit details
    Browse the repository at this point in the history

  6. use next() to return the formatted vector in axes map function

    @Frix-x
    Frix-x committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a9a0a3e View commit details
    Browse the repository at this point in the history

  7. using walrus operator to simplify logic in GraphCreatorFactory

    @Frix-x
    Frix-x committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f3c1917 View commit details
    Browse the repository at this point in the history