Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.12 #123

Closed
wants to merge 4 commits into from
Closed

Conversation

jorenham
Copy link

supersedes #122

@jorenham jorenham changed the base branch from main to develop October 22, 2023 23:18
@katdom13
Copy link

katdom13 commented Nov 8, 2023

Hi @jorenham ,
This looks good. A suggestion would be to add the classifier for Python 3.12 in setup.py:
https://github.com/Frojd/wagtail-geo-widget/blob/main/setup.py#L60

And maybe add an entry on the CHANGELOG.md: https://github.com/Frojd/wagtail-geo-widget/blob/main/CHANGELOG.md

Thanks!

@jorenham
Copy link
Author

jorenham commented Nov 9, 2023

@katdom13 Your suggestions have been implemented 👌🏻

@marteinn
Copy link
Member

@jorenham Apologies, I missed this PR. Python 3.12 support has already been added, but I have included your regex fix in cceb38f. Also many thanks to @katdom13 for providing support and feedback.

@marteinn marteinn closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants