Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing under the Zlib license? #66

Open
Lokathor opened this issue Dec 26, 2019 · 6 comments
Open

Releasing under the Zlib license? #66

Lokathor opened this issue Dec 26, 2019 · 6 comments

Comments

@Lokathor
Copy link
Contributor

Just wondering if you'd be interested in adding the Zlib license as a license option for this crate.

@oyvindln
Copy link
Collaborator

I wouldn't have any issue with that personally, but it would require getting permission from everone that have contributed. Is there any specificireason for wanting zlib in addition to the current licences?

@Lokathor
Copy link
Contributor Author

Just that this is a zlib-format-processing library, so it would be nice to have the zlib license to go with it.

Personally I've switched to using Zlib over MIT and trying to promote its use because there's less attribution requirements if the code is packaged into a binary. I think that makes it easier for folks to distribute their binaries, particularly when many rust binaries end up incorporating 50+ crates (I've seen as high as 400).

@Frommi
Copy link
Owner

Frommi commented Dec 29, 2019

Yeah, I think that is a good idea.

@Lokathor
Copy link
Contributor Author

Would still be interested if I started this PR?

I would suggest that the re-license process move the crate to Zlib OR Apache-2.0 OR MIT if we're going to do a re-license at all.

  • Zlib for the niceness of being a zlib crate so we should support the Zlib license (as discussed)
  • Apache-2.0 OR MIT because of course this is a rust crate and it is nice for users to also have the standard rust license pair available.

There is no actual harm in having more than one license option available, so that should be fine.

@Lokathor
Copy link
Contributor Author

Update: the rust crate is now under zlib/apache2/mit, the C api wrapping it is not yet changed.

@Lokathor
Copy link
Contributor Author

Lokathor commented Oct 9, 2020

Update: miniz_oxide-0.4.3 is release with the additional license options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants