Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing errors mo3 #293

Open
wintstar opened this issue Jan 10, 2024 · 3 comments
Open

Typing errors mo3 #293

wintstar opened this issue Jan 10, 2024 · 3 comments

Comments

@wintstar
Copy link

var audio, mo3, ogg;

This should be mp3 and not mo3?

var audio, mp3, ogg;

@zwiebus
Copy link

zwiebus commented Jan 13, 2024

In terms of content yes, but there is a mo3 format :
https://filext.com/de/dateiendung/MO3 ...
So not sure if this could be meant

@wintstar
Copy link
Author

It is a typing error. No .mo3 file will be used, look:

https://github.com/Frug/AJAX-Chat/tree/psr-4/public/sounds

It relates to the branch "psr-4" that is not yet official version 0.9.0.

I still have some errors / improvements. But I'm still thinking since this branch is not yet "master", to publish it with me or to create some Pull requests here.

wintstar added a commit to wintstar/AJAX-Chat that referenced this issue Jan 14, 2024
@zwiebus
Copy link

zwiebus commented Jan 17, 2024

I also use the psr-4 branch.
The reason was of course that it runs near perfectly with php 8.2.
However, i have already made some adjustments.
So i have not found any other errors after that so far, at least none that limit the functionality.
I also see no reason for merge solved issues cause its no master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants