Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify MetadataStorage impl to store unrecorded_blocks efficiently #2454

Open
MitchTurner opened this issue Nov 24, 2024 · 1 comment · May be fixed by #2468
Open

Modify MetadataStorage impl to store unrecorded_blocks efficiently #2454

MitchTurner opened this issue Nov 24, 2024 · 1 comment · May be fixed by #2468
Assignees
@MitchTurner

Comments

@MitchTurner
Copy link
Member

The list can grow very large, so we need to find a data structure that doesn't store every value redundantly for each new block.
@MitchTurner MitchTurner mentioned this issue Nov 24, 2024
Merged
2 tasks
@MitchTurner
Copy link
Member Author

Another solution than keeping the unrecorded_blocks on the metadata, is moving it to an adapter for AlgorithmUpdater So it is generic for some T: UnrecordedBlosksHistory, then we don't need to support iteratng over all heights, and can just use KV lookups.

@MitchTurner MitchTurner linked a pull request Nov 29, 2024 that will close this issue
Open
2 tasks
@MitchTurner MitchTurner self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitchTurner MitchTurner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unrecorded blocks abstraction to gas price algo FuelLabs/fuel-core
1 participant
@MitchTurner