Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-gate mutable field access trait methods #802

Closed
wants to merge 2 commits into from

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Aug 15, 2024

Closes #799

This is technically a breaking change, but anybody relying on this is doing something wrong.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@Dentosal Dentosal self-assigned this Aug 15, 2024
@Dentosal
Copy link
Member Author

Doesn't seem like a sensible thing to do, most of them seem to be actually used. I'll decide what to do about the issue later.

@Dentosal Dentosal closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature-gate _mut functions for tx field traits
1 participant